Skip to content

feat: Multi-Purpose Tokens (MPT) #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 66 commits into from
Dec 12, 2024
Merged

feat: Multi-Purpose Tokens (MPT) #732

merged 66 commits into from
Dec 12, 2024

Conversation

@khancode
Copy link
Contributor

@khancode khancode commented Jul 19, 2024 •
edited
Loading

High Level Overview of Change

Adds Multi-Purpose Tokens (MPT) feature.

Context of Change

XLS-33 spec

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update CHANGELOG.md?

  • Yes
  • No, this change does not impact library users

Test Plan

Adds unit/integ tests for new transactions.

@khancode khancode changed the title feat: MPT feat: MPT (Multi-purpose Token) Jul 19, 2024
@khancode khancode changed the title feat: MPT (Multi-purpose Token) feat: Multi-Purpose Tokens (MPTs) Jul 19, 2024
@khancode khancode changed the title feat: Multi-Purpose Tokens (MPTs) feat: Multi-Purpose Tokens (MPT) Jul 19, 2024
khancode added 25 commits July 19, 2024 19:34
@khancode
update CHANGELOG
0510c09
@khancode
remove redundant account
b048781
@khancode
add int to hex util and MPTokenIssuanceCreate integ test (commented)
6993c1b
@khancode
fix lint error
2a5bcb8
@khancode
fix return types of int_conversions
c793141
@khancode
add MPTAmount support in Payment tx and binary-codec
9fdee49
@khancode
fix Self import in MPTAmount
0566f25
@khancode
Revert "fix Self import in MPTAmount"
bc6ea59 
This reverts commit 0566f25.
@khancode
Revert "add MPTAmount support in Payment tx and binary-codec"
6a55a1d 
This reverts commit 9fdee49.
@khancode
use Python ^3.11 and poetry update dependencies
1d75779
@khancode
Revert "use Python ^3.11 and poetry update dependencies"
54471cd 
This reverts commit 1d75779.
@khancode
use Python ^3.10 and poetry update dependencies
84421b6
@khancode
Revert "use Python ^3.10 and poetry update dependencies"
88c6f32 
This reverts commit 84421b6.
@khancode
remove Python 3.7 support to fix dependency installation and use 3.8 …
76de09f 
…as new default #737
@khancode
remove python 3.7 from unit test; part of #737
af6ee29
@khancode
Revert "Revert "add MPTAmount support in Payment tx and binary-codec""
a995cf1 
This reverts commit 6a55a1d.
@khancode
Revert "Revert "fix Self import in MPTAmount""
dbeb5e7 
This reverts commit bc6ea59.
@khancode
resolve lint errors
71de9df
@khancode
resolve mypy errors
8cbf809
@khancode
Merge branch 'main' into mpt
5c14d23
@khancode
add MPTokenAuthorize tx
c1a9b4d
@khancode
fix lint error
75ada8b
@khancode
fix lint on REQUIRED
5c1bd40
@khancode
add mpt_issuance and mptoken to ledger entries
e5ebdcd
@khancode
add ledger entry tests
2f4991d
achowdhry-ripple
achowdhry-ripple reviewed Dec 11, 2024
View reviewed changes
achowdhry-ripple
achowdhry-ripple reviewed Dec 11, 2024
View reviewed changes
@achowdhry-ripple
Copy link
Collaborator

Same as the comment from the js library, am assuming the getBalanceChanges utility here would need to be modified in the same way (or have a comment and raise an issue to track the addition later on)

achowdhry-ripple
achowdhry-ripple approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@achowdhry-ripple achowdhry-ripple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shawnxie999
shawnxie999 reviewed Dec 11, 2024
View reviewed changes
shawnxie999
shawnxie999 reviewed Dec 11, 2024
View reviewed changes
shawnxie999
shawnxie999 reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. Might be useful to test serialization/deserialization of MPTokenIssuance and MPToken objects

@khancode
Copy link
Contributor Author

I think it looks good. Might be useful to test serialization/deserialization of MPTokenIssuance and MPToken objects

xrpl-py doesn't support ledger objects yet so that's why they're excluded for now.

@khancode khancode requested a review from shawnxie999 December 12, 2024 01:52
shawnxie999
shawnxie999 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@khancode khancode linked an issue Dec 12, 2024 that may be closed by this pull request
Update get_balance_changes to include MPT #782
Open
@khancode khancode merged commit 864f7b9 into main Dec 12, 2024
21 of 22 checks passed
@khancode khancode deleted the mpt branch December 12, 2024 02:18
@coderabbitai coderabbitai bot mentioned this pull request Apr 14, 2025
Open
@coderabbitai coderabbitai bot mentioned this pull request May 27, 2025
Merged
8 tasks
@coderabbitai coderabbitai bot mentioned this pull request Jun 6, 2025
Merged
9 tasks
LimpidCrypto pushed a commit to LimpidCrypto/xrpl-py that referenced this pull request Jun 7, 2025
@khancode @LimpidCrypto
feat: Multi-Purpose Tokens (MPT) (XRPLF#732)
eabbec8 
Adds Multi-Purpose Tokens (MPT) feature.
@sappenin sappenin mentioned this pull request Jun 17, 2025
Open
@coderabbitai coderabbitai bot mentioned this pull request Jul 23, 2025
Merged
9 tasks
@coderabbitai coderabbitai bot mentioned this pull request Sep 4, 2025
Closed
9 tasks
This was referenced Sep 18, 2025
Open
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 1, 2025
Closed
9 tasks
@coderabbitai coderabbitai bot mentioned this pull request Oct 20, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@shawnxie999 shawnxie999 shawnxie999 approved these changes

@achowdhry-ripple achowdhry-ripple achowdhry-ripple approved these changes

@ckeshava ckeshava Awaiting requested review from ckeshava

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update get_balance_changes to include MPT

4 participants

@khancode @achowdhry-ripple @shawnxie999